Fix loaded relation index lookups in StoredWorkflow#361
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 577 579 +2
===========================================
Files 62 62
Lines 2003 2007 +4
===========================================
+ Hits 2003 2007 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace firstWhere('index', ...) lookups on loaded logs and timers relations with direct raw-attribute checks.
Prevent replay paths from ever treating index like an Eloquent relation/method, which matches the reported StoredWorkflowLog::index() failure.
Add regression coverage to ensure loaded relation lookups do not fall back to firstWhere() again.
Why
The reported crash happens while replaying workflow state for child/activity stubs. The stack trace points at findLogByIndex(), and the risky part was the in-memory lookup against an already-loaded Eloquent collection. This change hardens that path and the equivalent timer lookup as well.
I couldn’t reproduce the exact exception but this fixes the code path implicated by the report and adds tests to keep it from regressing.
Fixes #360