Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
![dust-agent[bot]](https://avatars.githubusercontent.com/in/1117438?s=60&v=4){kind=small}
tdraier
force-pushed
the
change-subscription-warning-for
branch
2 times, most recently
from
779ffce to
337d1fc
Compare
| let description: string; | ||
| if (isEnterprise) { | ||
| description = | ||
| "Please reach out to your account manager to ensure continuity — no changes will be made without prior notice."; |
There was a problem hiding this comment.
If they do nothing we still remove data after x days so I'm afraid they need to still act and this wording is misleading 🙉
| {title} | ||
| </span> | ||
| <span className="text-sky-800 dark:text-sky-800-night"> | ||
| When your {isTrial ? "trial" : "subscription"} wraps up, your |
There was a problem hiding this comment.
Why not keeping a proper wording for trials?
There was a problem hiding this comment.
I took the wording from @thib-martin here : https://github.com/dust-tt/tasks/issues/7290#issuecomment-4171274404 .
There was a problem hiding this comment.
Yes but it's hard to get the full picture when you look at the code no?
I don't think he thought about trials when he built his card, this is our job to think about edge cases :D
There was a problem hiding this comment.
Actually the wording the one we had in SubscriptionPage, same for trials and pro (when there is an endDate) - do we want to have different messages for both ?
Note that for pilots I have no clean way to detect them.
tdraier
force-pushed
the
change-subscription-warning-for
branch
from
337d1fc to
6bd972a
Compare
2 participants
Description
Soften end-of-subscription warning messages for Enterprise plans.
Fixes https://github.com/dust-tt/tasks/issues/7290
The current wording ("Connections will be deleted and members will be revoked") is too alarming for Enterprise customers in the process of renewing or upgrading.
SubscriptionPage.tsx): Enterprise plans show "Please reach out to your account manager to ensure continuity." instead of the destructive warning.TrialBanner.tsx): Enterprise plans get "Your current subscription period ends in X days" with "Please reach out to your account manager to ensure continuity." The "Subscribe to Dust" button is hidden (not relevant for enterprise).Non-enterprise plans keep existing behavior unchanged.
Tests
Type-checking passes. UI-only change, gated on
isEntreprisePlanPrefix(plan.code).Risk
Low — display-only change scoped to enterprise plan banners. No impact on non-enterprise plans.
Deploy Plan
Standard deploy, no special steps needed.