Skip to content

[Tool Calls] Emit tool_call_started for OpenAI chat#23703

Merged
philipperolet merged 3 commits intomainfrom
pr/404-openai-chat-tool-call-started
Apr 3, 2026
Merged

[Tool Calls] Emit tool_call_started for OpenAI chat#23703
philipperolet merged 3 commits intomainfrom
pr/404-openai-chat-tool-call-started

Conversation

@philipperolet
Copy link
Copy Markdown
Contributor

@philipperolet philipperolet commented Apr 3, 2026

Description

Follows #23634.

Emit tool_call_started from the OpenAI chat-completions adapter as soon as a tool name is known, then re-emit it once the call id arrives later in the stream.

Add a focused adapter test covering the name-first, id-later case.

Risks

Blast radius: OpenAI chat-completions event normalization, including providers that use the same adapter such as Fireworks.
Risk: low

Deploy Plan

  • pmrr
  • deploy front

Tests

  • npm test lib/api/llm/utils/openai_like/chat/openai_to_events.test.ts

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
playground Ignored Ignored Preview Apr 3, 2026 11:23am
storybook Ignored Ignored Preview Apr 3, 2026 11:23am

Request Review

Copy link
Copy Markdown
Contributor

@dust-agent dust-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding Rules LGTM \o/

@philipperolet philipperolet requested a review from pmilliotte April 3, 2026 14:16
@philipperolet philipperolet merged commit c0f12af into main Apr 3, 2026
38 checks passed
@philipperolet philipperolet deleted the pr/404-openai-chat-tool-call-started branch April 3, 2026 14:16
Copy link
Copy Markdown
Contributor

@pmilliotte pmilliotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants