Allow HGRCPATH from environment to propagate to mercurial#86
Allow HGRCPATH from environment to propagate to mercurial#86jedbrown wants to merge 1 commit intodusty-phillips:masterfrom
Conversation
If the user sets HGRCPATH, it is likely because they want to affect the environment used to make commits (relevant when translating git lightweight tags to mercurial tags) or because they would like to add an extension such as keyring or schemes to the environment. We are not aware of Mercurial extensions that would negatively affect the behavior of the interfaces that Gitifyhg uses. This reverts part of 468a4fe Suggested-by: Felipe Contreras <felipe.contreras@gmail.com>
|
Funny, I recall sending a patch for this, and discussing it in the mailing list. This commit message makes it look as if this idea popped on your head out of nowhere. |
|
@felipec You sent a patch for something else (in the test suite) and said you were not interested in submitting a patch for this. Gitifyhg doesn't have a convention of using tags to name everyone that discussed a topic (as with most projects that prefer to discuss commits in pull requests [1]). You're welcome to send another version of this patch. [1] FWIW, I think mailing lists are better than PRs, but only when everyone uses decent mailers and is disciplined about structuring commits. I work on projects that work both ways. Gitifyhg is not my project, but I adopt its conventions when playing here. |
|
I would have done `git commit --author="Sandor Bodo-Merle sbodomerle@gmail.com"', or at the very least "Original patch by". But whatever, it's not like gitifyhg has any standards at all. The original author of the whole code is not even mentioned. |
|
@felipec Maybe it would help to look at the commit itself rather than the PR summary: |
|
Ahh, I didn't notice. All right. |
|
Wait, this is for gitifyhg.py. |
2 participants
If the user sets HGRCPATH, it is likely because they want to affect the
environment used to make commits (relevant when translating git
lightweight tags to mercurial tags) or because they would like to add an
extension such as keyring or schemes to the environment.
We are not aware of Mercurial extensions that would negatively affect
the behavior of the interfaces that Gitifyhg uses.
This reverts part of 468a4fe