Remove reporting library terminology#6
Merged
dyladan merged 3 commits intonamed-tracer-updatefrom Jan 14, 2020
Merged
Conversation
z1c0
approved these changes
Jan 9, 2020
arminru
approved these changes
Jan 9, 2020
|
I'm fine with sticking to the already established term "instrumentation library" but agree with @danielkhan (open-telemetry#76 (comment)) that "reporting library" would be more precise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pursuant to yuri's comment here open-telemetry#76 (comment) I think we can remove the terminology "reporting library" and simply use the term "instrumentation library" which already exists. I don't think it really affects the substance or clarity of the OTEP.
I think you are all gone for the day already, but if this PR is merged it will automatically update the PR that is on the master repo. So, if you agree with this change merge this and if not just close it.