patch: Handle failed responses from Davis AI #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-kreuzberger-dtx
requested review from
MrManny,
krisdyna and
raphael-wigoutschnigg-dt
as code owners
MrManny
approved these changes
Aug 28, 2025
Collaborator
MrManny
left a comment
MrManny
left a comment
There was a problem hiding this comment.
I haven't interacted with the DAVIS API that much, but on a surface level this looks bueno.
Collaborator
|
I also don't think we should throw an exception instead. |
christian-kreuzberger-dtx
force-pushed
the
patch/122/handle-davis-error-response
branch
from
9e3c899 to
d58da80
Compare
christian-kreuzberger-dtx
deleted the
patch/122/handle-davis-error-response
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122
edit: though please let me know, if we should rather throw an exception.