patch: Slightly improve error handling when connecting the first time #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-kreuzberger-dtx
requested review from
MrManny,
dt-benedict,
krisdyna and
raphael-wigoutschnigg-dt
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling during the initial Dynatrace connection test by removing retry logic and enhancing error messages. The change simplifies the connection flow to either succeed or fail immediately with better error details.
Key changes:
- Removed retry logic with exponential backoff for initial connection testing
- Extracted error handling utility to separate module for better organization
- Enhanced error messages with visual indicators (✅/❌) and more detailed information
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/utils/dynatrace-connection-utils.ts | New utility module for handling ClientRequestError with enhanced error formatting |
| src/index.ts | Refactored connection testing to remove retry logic, use new error handler, and improve error messages |
| CHANGELOG.md | Added entry documenting the improved error handling feature |
MrManny
approved these changes
Oct 15, 2025
Collaborator
MrManny
left a comment
MrManny
left a comment
There was a problem hiding this comment.
LGTM, with or without Copilot's spelling suggestions :)
christian-kreuzberger-dtx
force-pushed
the
patch/improve-error-handling
branch
from
d250904 to
354449c
Compare
christian-kreuzberger-dtx
force-pushed
the
patch/improve-error-handling
branch
from
354449c to
a3c39b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly improve error handling (also refactored the code a bit, and removed the retry logic; either it works the first time, or it doesn't). I hope this helps to pinpoint the problem in #199 .
Old behaviour
New behaviour
