fix: Improve filtering for find_entity_by_name tool #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-kreuzberger-dtx
requested review from
MrManny,
dt-benedict,
krisdyna and
raphael-wigoutschnigg-dt
as code owners
christian-kreuzberger-dtx
force-pushed
the
patch/fix-find-entities-tool
branch
from
fb07eb7 to
bd567fb
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the find_entity_by_name tool where the filtering logic was accidentally removing valid entities instead of invalid ones when using the classic entities API fallback.
Key Changes:
- Corrected the entity property names in the filter condition from
entity.type/entity.nametoentity['entity.type']/entity['entity.name'] - Added console logging to track the filtering process
- Updated CHANGELOG.md to document the bug fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.ts | Fixed filter condition to use correct property names (entity['entity.type'] and entity['entity.name']) and added debug logging |
| CHANGELOG.md | Documented the bug fix in the unreleased changes section |
MrManny
requested changes
Oct 21, 2025
Collaborator
MrManny
left a comment
MrManny
left a comment
There was a problem hiding this comment.
Probably needs a little fix-up, unless I misunderstood the code
christian-kreuzberger-dtx
force-pushed
the
patch/fix-find-entities-tool
branch
2 times, most recently
from
f3afcd1 to
ad19ea3
Compare
christian-kreuzberger-dtx
force-pushed
the
patch/fix-find-entities-tool
branch
from
ad19ea3 to
4f30b81
Compare
MrManny
approved these changes
Oct 22, 2025
Collaborator
MrManny
left a comment
MrManny
left a comment
There was a problem hiding this comment.
Copilot's complaints aside, I think this is gucci. Probably don't need the String(entity.id) later, but it never hurts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we accidentally filtered out the "good" ones for the fallback.
Fixed:
