fix: don't show consumption in percentage if no budget is set #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrManny
requested review from
christian-kreuzberger-dtx,
dt-benedict,
krisdyna and
raphael-wigoutschnigg-dt
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the display of DQL query budget usage information by conditionally showing the usage percentage only when a budget limit is actually set, making the output more meaningful for users.
Key changes:
- Modified budget status display logic to check if a budget limit exists before calculating and showing usage percentage
- Updated CHANGELOG.md to document this user-facing behavior change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.ts | Added conditional logic to display usage percentage only when budgetLimitGB > 0, otherwise shows only scanned GB |
| CHANGELOG.md | Added entry documenting the change to budget usage display behavior |
MrManny
force-pushed
the
patch/fix-budget-calculation-when-there-is-no-budget
branch
from
0751627 to
b6bf070
Compare
MrManny
force-pushed
the
patch/fix-budget-calculation-when-there-is-no-budget
branch
from
b6bf070 to
b18cbd6
Compare
Collaborator
Author
|
I am not authorized to merge this 😅 |
christian-kreuzberger-dtx
deleted the
patch/fix-budget-calculation-when-there-is-no-budget
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how budget usage information is displayed to users. The main improvement is that the usage percentage is no longer shown when no budget is set, making the output clearer and more accurate.
User-facing improvements:
src/index.ts)CHANGELOG.mdto inform users of the updated behavior.