ci: warmup goose before tests to avoid ETXTBSY race#2023
Open
matthewlouisbrockman wants to merge 5 commits intomainfrom
Open
ci: warmup goose before tests to avoid ETXTBSY race#2023matthewlouisbrockman wants to merge 5 commits intomainfrom
matthewlouisbrockman wants to merge 5 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Contributor
Author
|
something funky going on with the caching; not sure i understand it as well as I'd like; calling it for now, at least the main issue's fixed with the tests not failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warms up goose before running tests to avoid ETXTBSY races on tests.
Getting sporadic failing unit tests due to "text file busy" when applying goose migrations, e.g. https://github.com/e2b-dev/infra/actions/runs/22504612582/job/65200077694
Also saves us about 20 seconds on the unit tests looks like -
example prior
Note
Low Risk
Low risk CI-only change that adds a pre-run step to compile/cache
goosefor the DB test job; main risk is only potential workflow flakiness if the tool invocation fails in CI.Overview
Updates the PR test workflow to pre-warm the
gooseGo tool (viago tool goose --version) before runningpackages/dbtests, aiming to avoid intermittentETXTBSYfailures when migrations run and to speed up the test job by caching the compiled binary.Written by Cursor Bugbot for commit 8990e32. This will update automatically on new commits. Configure here.