Skip to content

[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.#504

Merged
MiguelCompany merged 2 commits intomasterfrom
fix/mac-dylib-generation
Sep 25, 2025
Merged

[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.#504
MiguelCompany merged 2 commits intomasterfrom
fix/mac-dylib-generation

Conversation

@Danipiza
Copy link
Contributor

@Danipiza Danipiza commented Sep 22, 2025 •
edited by richiware
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Danipiza
[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.
0410f4a 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza Danipiza mentioned this pull request Sep 22, 2025
Merged
8 tasks
richiware
richiware requested changes Sep 23, 2025
View reviewed changes
@MiguelCompany MiguelCompany added this to the v4.1.1 milestone Sep 24, 2025
@MiguelCompany
Refs #23543. Apply suggestion
ecd0cf5 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 25, 2025
@MiguelCompany MiguelCompany merged commit 496811e into master Sep 25, 2025
5 checks passed
@MiguelCompany MiguelCompany deleted the fix/mac-dylib-generation branch September 25, 2025 07:42
@MiguelCompany
Copy link
Member

MiguelCompany commented Sep 25, 2025

@Mergifyio backport 3.3.x

@mergify
Copy link

mergify bot commented Sep 25, 2025 •
edited
Loading

backport 3.3.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Sep 25, 2025
@Danipiza @MiguelCompany @mergify
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#504)
820e0a7 
* [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* Refs #23543. Apply suggestion

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 496811e)
@mergify mergify bot mentioned this pull request Sep 25, 2025
Merged
9 tasks
MiguelCompany added a commit that referenced this pull request Sep 25, 2025
@mergify @Danipiza @MiguelCompany
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#504) (#507)
2ad5406 
* [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.



* Refs #23543. Apply suggestion



---------




(cherry picked from commit 496811e)

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: DannyP39 <98972125+Danipiza@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Copy link
Member

MiguelCompany commented Sep 26, 2025

@Mergifyio backport 4.0.x

@mergify
Copy link

mergify bot commented Sep 26, 2025 •
edited
Loading

backport 4.0.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Sep 26, 2025
@Danipiza @MiguelCompany @mergify
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#504)
e32d946 
* [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* Refs #23543. Apply suggestion

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 496811e)
@mergify mergify bot mentioned this pull request Sep 26, 2025
Merged
9 tasks
MiguelCompany added a commit that referenced this pull request Sep 26, 2025
@mergify @Danipiza @MiguelCompany
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#504) (#512)
bfe6662 
* [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.



* Refs #23543. Apply suggestion



---------




(cherry picked from commit 496811e)

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Co-authored-by: DannyP39 <98972125+Danipiza@users.noreply.github.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany left review comments

@richiware richiware richiware approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v4.1.1 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@Danipiza @MiguelCompany @richiware