Skip to content

Correct 'Mac OS' to 'macOS' in README#1382

Open
joespeed wants to merge 1 commit intoeclipse-iceoryx:mainfrom
joespeed:patch-1
Open

Correct 'Mac OS' to 'macOS' in README#1382
joespeed wants to merge 1 commit intoeclipse-iceoryx:mainfrom
joespeed:patch-1

Conversation

@joespeed
Copy link
Copy Markdown

@joespeed joespeed commented Feb 28, 2026

... because of my arm64 Macbook Pro😉

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add posix ipc example)
    • Keep in mind to use the same email that was used to sign the Eclipse Contributor Agreement
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Closes #

... because of my arm64 Macbook Pro😉
@elfenpiff
Copy link
Copy Markdown
Contributor

Great to have you on board @joespeed . We have a rigorous contribution process where we are also unable to make any exception - but I will guide you through it.

  1. Can you please sign the eclipse committer agreement with the e-mail you have used to commit the documentation fix, see: https://www.eclipse.org/legal/eca/ You need to create here an account with that email and just accept the ECA.
  2. Every commit needs to be linked to a github issue to establish traceability later (required for safety certification). For documentation fixes we use the issue documentation fixes #4 , so could you please add [#4] as a prefix to your commit message and then call git push -f to override your old git message.

Thank you, and we are looking forward to welcoming you to the glorious hall of fame of iceoryx contributors.

@elfenpiff elfenpiff self-requested a review February 28, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants