[#1425] Add missing getters for PublishSubscribe Publisher#1428
Open
maxence-d wants to merge 9 commits intoeclipse-iceoryx:mainfrom
Open
[#1425] Add missing getters for PublishSubscribe Publisher#1428maxence-d wants to merge 9 commits intoeclipse-iceoryx:mainfrom
maxence-d wants to merge 9 commits intoeclipse-iceoryx:mainfrom
Conversation
elBoberido
reviewed
Mar 13, 2026
Member
elBoberido
left a comment
There was a problem hiding this comment.
Looks good overall. Just some formatting issues. Could you also try to add these new functions to the Python bindings?
25951b0 to
ba04cf0
Compare
ba04cf0 to
bb7bac0
Compare
Contributor
|
@maxence-d, great to see your first, of hopefully many, pull requests! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
- Coverage 77.45% 77.43% -0.03%
==========================================
Files 419 419
Lines 39349 39375 +26
Branches 1284 1285 +1
==========================================
+ Hits 30479 30489 +10
- Misses 7833 7847 +14
- Partials 1037 1039 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Author
|
I just saw the coverage values |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Adds
allocation_strategy()andmax_loaned_samples()getters to Publisher of PublishSubscribe services.The code re-uses the same logic as other existing getters.
Pre-Review Checklist for the PR Author
Convert to draft)iox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)PR Reviewer Reminders
References
Closes #1245