Skip to content

[#996] Refactor BumpAllocators#1582

Open
dkroenke wants to merge 9 commits intoeclipse-iceoryx:mainfrom
ekxide:iox2-996-refactor-bump-allocator-in-memory-and-elementary
Open

[#996] Refactor BumpAllocators#1582
dkroenke wants to merge 9 commits intoeclipse-iceoryx:mainfrom
ekxide:iox2-996-refactor-bump-allocator-in-memory-and-elementary

Conversation

@dkroenke
Copy link
Copy Markdown
Contributor

Notes for Reviewer

  • Consolidate BumpAllocator from iceoryx2-bb-memory into BumpAllocator in iceoryx2-bb-elementary to avoid maintaining two BumpAllocator implementations with almost same functionality
  • add Traits for core::ptr::NonNull to make use of safe functions from_ref() and from_mut and use it in the API Adaptions for the BumpAllocator
  • Rename bump_allocator module in iceoryx2-cal to shm_bump_allocator to better distinguish it from the existing bump_allocator module.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
    • Commit messages have the issue ID ([#123] Add posix ipc example)
    • Keep in mind to use the same email that was used to sign the Eclipse Contributor Agreement
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes

PR Reviewer Reminders

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

References

Closes #996

@dkroenke dkroenke requested a review from elBoberido April 24, 2026 07:44
@dkroenke dkroenke self-assigned this Apr 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 90.07634% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.51%. Comparing base (86e8f75) to head (0dfb87e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2-bb/elementary/src/bump_allocator.rs 81.48% 10 Missing ⚠️
iceoryx2-bb/elementary-traits/src/non_null.rs 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
- Coverage   77.70%   77.51%   -0.19%     
==========================================
  Files         419      419              
  Lines       40310    39871     -439     
  Branches     1306     1302       -4     
==========================================
- Hits        31321    30905     -416     
+ Misses       7924     7905      -19     
+ Partials     1065     1061       -4     
Flag Coverage Δ
CPP 67.29% <ø> (-1.63%) ⬇️
Rust 77.37% <90.07%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
iceoryx2-bb/container/src/flatmap.rs 79.71% <100.00%> (+0.59%) ⬆️
iceoryx2-bb/container/src/queue.rs 90.83% <100.00%> (+0.25%) ⬆️
iceoryx2-bb/container/src/slotmap.rs 90.38% <100.00%> (+0.28%) ⬆️
...ryx2-bb/container/src/string/relocatable_string.rs 70.29% <ø> (ø)
...ceoryx2-bb/container/src/vector/relocatable_vec.rs 82.47% <ø> (ø)
iceoryx2-bb/elementary/src/package_version.rs 72.41% <ø> (ø)
iceoryx2-bb/lock-free/src/mpmc/bit_set.rs 94.87% <100.00%> (+0.10%) ⬆️
iceoryx2-bb/lock-free/src/mpmc/container.rs 95.56% <100.00%> (+0.08%) ⬆️
iceoryx2-bb/lock-free/src/mpmc/unique_index_set.rs 93.41% <100.00%> (+0.11%) ⬆️
iceoryx2-bb/lock-free/src/spsc/index_queue.rs 85.86% <100.00%> (+0.22%) ⬆️
... and 9 more

... and 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use 'NonNull' in 'elementary/BumpAllocator'

1 participant