ReliabilityLayerParameters set for downlink request .

[madhushreegc]

I want to set ReliabilityLayerParameters for downlink request from Leshan .

Is there any idea of adding ReliabilityLayerParameters as parameter in method public void send(Registration destination, DownlinkRequest request,
ResponseCallback responseCallback, ErrorCallback errorCallback) {
requestSender.send(destination, request, DEFAULT_TIMEOUT, responseCallback, errorCallback);

Regards,
Madhushree.

[sbernard31]

Currently the only easy way to change reliability parameter affect the whole stack (meaning all requests use same parameters), see https://github.com/eclipse/leshan/wiki/Request-Timeout#coap-timeout
So no easy way to change it by request.

At short term, with a lot of code duplicate, you could maybe achieve this by extending LWM2M request classes you need to configure and create a custom request sender but clear not an elegant solution.

At mid term, this is maybe a feature we should add 🤔

But before, I would like to better understand your needs.
Do you need to set this by request or by destination ?
I mean either you set the parameter for each requests ?
or
you set parameters by destination/registration and so all request for a given registration could use specific reliability parameters ?

[madhushreegc]

Hi Simon,

We need to set the parameters for each request . Each endpoint(devices) may have different sleeping cycles, based on that we need to set the reliability layer parameters while sending the downlink request .

As of now , I am setting it in MessageInterceptor

@Override
public void sendRequest(Request request) {
		
		Map<String, String> reliabilityLayerTimer = new HashMap<String, String>();
		
		Registration registration = customRedRegStore.getRegistrationByAdress(request.getDestinationContext().getPeerAddress());
		
		//TODO get the endpoint by registration address:
        
        ReliabilityLayerParameters reliabilityLayerParameters = getReliabilityLayerParam(registration.getEndpoint());
        
        request.setReliabilityLayerParameters(reliabilityLayerParameters);
		
}

It is good , if below method can be extended by adding ReliabilityLayerParameters as a parameter .

method public void send(Registration destination, DownlinkRequest request,
ResponseCallback responseCallback, ErrorCallback errorCallback) {
requestSender.send(destination, request, DEFAULT_TIMEOUT, responseCallback, errorCallback);

Thanks,
Madhushree.

[sbernard31]

For shortterm/quick haack, you're right probably easier to use MessageInterceptor. 🤔

It is good , if below method can be extended by adding ReliabilityLayerParameters as a parameter .

Unfortunately, we can not reused ReliabilityLayerParameters directly because of class dependency issue. We need to abstract this. We can maybe add a Map named LowerLayerParameters ?

[madhushreegc]

Yes , even we can add a map . Some parameter to set the values .

Thank you.

[sbernard31]

I created a PR about this => #876

If you find time, I would appreciate if you check that it works for you.

(This PR aims leshan 1.2 but once you validate it I will integrate it in master branch (2.x))

[madhushreegc]

Thank you simon for adding the request . This is working.