Remove supportsJavaFloatSemantics CodeGenerator flag#8202
Merged
vijaysun-omr merged 1 commit intoeclipse-omr:masterfrom Apr 6, 2026
Merged
Remove supportsJavaFloatSemantics CodeGenerator flag#8202vijaysun-omr merged 1 commit intoeclipse-omr:masterfrom
vijaysun-omr merged 1 commit intoeclipse-omr:masterfrom
Conversation
0xdaryl
force-pushed
the
apx/removex87inst-nofloatsemantics
branch
from
4f6d855 to
cc2b69f
Compare
Contributor
Author
|
Jenkins build all |
When false, this flag has always been a poorly-worded reference to x87 floating point support. x87 support has been deprecated in OMR, and the flag was semantically true on every backend platform. Assume the flag is true and fold/remove code accordingly. Note that for AArch64 and RISC-V, this flag was not set in their respective CodeGenerators. This was an oversight, and functionality previously disabled in the optimizer guarded with this flag will now be enabled. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
0xdaryl
force-pushed
the
apx/removex87inst-nofloatsemantics
branch
from
cc2b69f to
d8d6139
Compare
Contributor
Author
|
Jenkins build all |
0xdaryl
changed the title
Contributor
Author
|
@vijaysun-omr : all required downstream changes have merged. Could you review this please (low priority)? |
vijaysun-omr
approved these changes
Apr 6, 2026
Contributor
|
Failures are known infra issues. Otherwise this change is a cleanup, with logic changed to be simpler (that I have reviewed) in several places calling the removed API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When false, this flag has always been a poorly-worded reference to x87 floating
point support. x87 support has been deprecated in OMR, and the flag was
semantically true on every backend platform. Assume the flag is true and
fold/remove code accordingly.
Note that for AArch64 and RISC-V, this flag was not set in their respective
CodeGenerators. This was an oversight, and functionality previously disabled
in the optimizer guarded with this flag will now be enabled.