Correct GetThreadState return value for Object.wait#21547
Merged
babsingh merged 1 commit intoeclipse-openj9:masterfrom Apr 3, 2025
Merged
Correct GetThreadState return value for Object.wait#21547babsingh merged 1 commit intoeclipse-openj9:masterfrom
babsingh merged 1 commit intoeclipse-openj9:masterfrom
Conversation
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
babsingh
reviewed
Apr 2, 2025
| break; | ||
| case JVMTI_VTHREAD_STATE_PINNED: | ||
| case JVMTI_VTHREAD_STATE_PARKED: | ||
| rc = JVMTI_JAVA_LANG_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_PARKED; |
Contributor
There was a problem hiding this comment.
JVMTI_JAVA_LANG_THREAD_STATE_WAITING was only introuced in JDK24. Appropriate ifdefs will need to be added. Otherwise, older JDKs will behave incorrectly.
Contributor
Author
There was a problem hiding this comment.
Are you thinking of JVMTI_VTHREAD_STATE_WAIT? It looks like JVMTI_JAVA_LANG_THREAD_STATE_WAITING has been in the code base for several years.
Contributor
There was a problem hiding this comment.
You are right. I read too quickly. i will launch the PR builds
Contributor
|
jenkins test sanity.functional amac jdk24 |
Contributor
|
jenkins test extended.openjdk amac jdk21,jdk24 |
Contributor
|
@theresa-m I noticed a new failure that has been documented before. Could you do an initial triage to see if it's related to your changes? If it's not, please create a new issue to track it. Once that's done, I'll go ahead and merge this PR. |
Contributor
Author
|
It doesn't look related to me, the failing test serviceability/jvmti/ObjectMonitorUsage/ObjectMonitorUsage.java does not call any of the methods that use From the javacore the test looks to be working on Thread.join when the failure occurs: I'll make a new issue for this. |
babsingh
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change #21408 passes and #21412 progresses past one failure.