Skip to content

Fix synchronization issues of notifying yielding vthreads#21753

Merged
babsingh merged 1 commit intoeclipse-openj9:masterfrom
thallium:jep491
May 1, 2025
Merged

Fix synchronization issues of notifying yielding vthreads#21753
babsingh merged 1 commit intoeclipse-openj9:masterfrom
thallium:jep491

Conversation

@thallium
Copy link
Copy Markdown
Contributor

@thallium thallium commented Apr 29, 2025

  • Prevent vthreads from being notified before being added to the wait list
  • Prevent Object.notify occuring between prepareVirtualThreadForUnmount
    and yieldPinnedContinuation to be ignored by unblocker

Copy link
Copy Markdown
Contributor

@fengxue-IS fengxue-IS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fengxue-IS
Copy link
Copy Markdown
Contributor

@thallium is this PR ready for merge or still draft?

@thallium
Copy link
Copy Markdown
Contributor Author

I think it' ready to merge.

@thallium thallium marked this pull request as ready for review April 30, 2025 21:11
@fengxue-IS
Copy link
Copy Markdown
Contributor

@babsingh please take a look

- Prevent vthreads from being notified before being added to the wait
list
- Prevent Object.notify occuring between prepareVirtualThreadForUnmount
and yieldPinnedContinuation to be ignored by unblocker

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
@babsingh
Copy link
Copy Markdown
Contributor

babsingh commented May 1, 2025

jenkins test sanity amac jdk24

@babsingh
Copy link
Copy Markdown
Contributor

babsingh commented May 1, 2025

jenkins compile alinux jdk21

@babsingh babsingh merged commit 3064ef1 into eclipse-openj9:master May 1, 2025
7 checks passed
thallium added a commit to thallium/aqa-tests that referenced this pull request May 6, 2025
….java test

Fixed by eclipse-openj9/openj9#21753.

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
thallium added a commit to thallium/aqa-tests that referenced this pull request May 6, 2025
Fixed by eclipse-openj9/openj9#21753.

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
pshipton pushed a commit to adoptium/aqa-tests that referenced this pull request May 7, 2025
Fixed by eclipse-openj9/openj9#21753.

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
@thallium thallium deleted the jep491 branch October 7, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants