Add special compilation flags for Interpreter in GCC13 and newer#23304
Add special compilation flags for Interpreter in GCC13 and newer#23304keithc-ca merged 1 commit intoeclipse-openj9:masterfrom
Conversation
| endif | ||
| </#if> | ||
|
|
||
| ifneq (,$(findstring $(GCC_MAJOR_VERSION),14)) |
There was a problem hiding this comment.
@keithc-ca is there a better way to do this that will work for gcc 14+, or actually gcc 13+?
There was a problem hiding this comment.
If we want to test for gcc 13+, we may need to resort to checking that it's not 1-12 (like line 183, but with filter):
ifeq (,$(filter $(GCC_MAJOR_VERSION),1 2 3 4 5 6 7 8 9 10 11 12)) # 13+
There was a problem hiding this comment.
Actually, I think line 183 is broken; e.g. gcc 10+ are mishandled there.
There was a problem hiding this comment.
I thought we might use $(intcmp), but it seems to require make version 4.4.1.
8e7e131 to
b26286d
Compare
keithc-ca
left a comment
There was a problem hiding this comment.
Please correct the commit message and this pull request title/description to reflect that the boundary is gcc 13+ (not 14+).
b26286d to
2ce23c4
Compare
79f53ca to
35375b0
Compare
|
Please squash. |
In certain JDK version when Interpreter code is compiled with GCC13, we observed sub-optimal performance. When using the GCC13 or newer for compiling VM, use these special compilation flags for Interpreter code that provides on par or better performance compared to GCC11. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
960950b to
99e950b
Compare
|
Squashed commits. |
|
Jenkins test sanity amac,plinux,xlinux,zlinux jdk25 |
|
Not sure if this test suppose to be excluded or not for JDK25 - seems like the failing test was added to JDK25 last week (ibmruntimes/openj9-openjdk-jdk25@be3a705) I do see other OSRTest excluded in [1], @pshipton / @keithc-ca is this one suppose to be excluded given we do not support WhiteBox ? |
|
Yes, I think The other failure I see with |
In certain JDK versions when interpreter code is compiled with GCC13, we observed sub-optimal performance. When using the GCC13 for compiling VM, use these special compilation flags for interpreter code that provides on par or better performance compared to GCC11.