Skip to content

Embed/relocate ASM via m-shade-p#185

Merged
kwin merged 1 commit intomainfrom
feature/shaded-asm-with-classifier
Mar 31, 2025
Merged

Embed/relocate ASM via m-shade-p#185
kwin merged 1 commit intomainfrom
feature/shaded-asm-with-classifier

Conversation

@kwin
Copy link
Contributor

@kwin kwin commented Mar 22, 2025

Attach as secondary artifact.
Primary artifact requires it on the classpath/exported from another OSGi bundle.

This closes #180

@kwin kwin requested review from cstamas and mcculls March 22, 2025 15:59
@kwin kwin force-pushed the feature/shaded-asm-with-classifier branch 2 times, most recently from 7a5e3bd to 108f3f7 Compare March 22, 2025 16:03
@kwin kwin force-pushed the feature/shaded-asm-with-classifier branch 3 times, most recently from efc94db to 349ef25 Compare March 23, 2025 15:39
@kwin kwin force-pushed the feature/shaded-asm-with-classifier branch 2 times, most recently from 3f9e42b to b4b717d Compare March 31, 2025 08:17
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@kwin kwin force-pushed the feature/shaded-asm-with-classifier branch from b4b717d to 529ca71 Compare March 31, 2025 08:20
Attach as secondary artifact.
Primary artifact requires it on the classpath/exported from another OSGi
bundle.
Let bnd generate import version ranges

This closes #180
@kwin kwin force-pushed the feature/shaded-asm-with-classifier branch from 529ca71 to fd60916 Compare March 31, 2025 08:21
@kwin kwin merged commit 981579d into main Mar 31, 2025
11 checks passed
@kwin kwin deleted the feature/shaded-asm-with-classifier branch March 31, 2025 08:23
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the asm-less JAR the default?

2 participants