Skip to content

More coverage #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstamas merged 3 commits into from
Apr 19, 2025
Merged

More coverage #196

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fdc062
More coverage
cstamas Apr 19, 2025
c29f5c3
Add other branch
cstamas Apr 19, 2025
092d6ef
Merge remote-tracking branch 'origin/main' into more-coverage
cstamas Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion .../codehaus/plexus/component/configurator/converters/composite/PropertiesConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void canConvertNegative()
}

@Test
public void testConvert()
public void testConvert1()
throws ComponentConfigurationException
{
XmlPlexusConfiguration config = new XmlPlexusConfiguration( "properties" );
Expand Down Expand Up @@ -63,4 +63,44 @@ public File alignToBaseDirectory( File path )
assertEquals( "value1", result.getProperty("key1") );
assertEquals( "value2", result.getProperty("key2") );
}

@Test
public void testConvert2()
throws ComponentConfigurationException
{
XmlPlexusConfiguration config = new XmlPlexusConfiguration( "properties" );

XmlPlexusConfiguration entry1 = new XmlPlexusConfiguration( "property" );
entry1.addChild( "name", "key1" );
entry1.addChild( "value", "value1" );
config.addChild( entry1 );
XmlPlexusConfiguration entry2 = new XmlPlexusConfiguration( "property" );
entry2.addChild( "name", "key2" );
entry2.addChild( "value", "value2" );
config.addChild( entry2 );

System.out.println(config);

Object object = new PropertiesConverter().fromConfiguration( null, config, Properties.class, null, null,
new ExpressionEvaluator()
{
@Override
public Object evaluate( String expression )
throws ExpressionEvaluationException
{
return expression;
}

@Override
public File alignToBaseDirectory( File path )
{
return null;
}
}, null );
assertTrue( object instanceof Properties );
Properties result = (Properties) object;
assertEquals(2, result.size() );
assertEquals( "value1", result.getProperty("key1") );
assertEquals( "value2", result.getProperty("key2") );
}
}