Skip to content

Sisu specific PreConstruct/PreDestroy annotations#76

Merged
cstamas merged 4 commits intoeclipse-sisu:masterfrom
cstamas:issue-58
Feb 27, 2023
Merged

Sisu specific PreConstruct/PreDestroy annotations#76
cstamas merged 4 commits intoeclipse-sisu:masterfrom
cstamas:issue-58

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Feb 15, 2023

Just like other annotations like Typed, Priority add "own" annotations for Lifecycle as well (while do support JSR250 if present).

This closes #58

@cstamas
Just like other annotations like Typed, Priority add
59e7ca9 
"own" annotations for Lifecycle as well (while do support
JSR250 if present).

This closes eclipse-sisu#58
@cstamas cstamas requested review from kwin and mcculls February 15, 2023 09:34
@cstamas cstamas self-assigned this Feb 15, 2023
kwin
kwin requested changes Feb 18, 2023
View reviewed changes
org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/PostConstruct.java Outdated
@@ -0,0 +1,37 @@
/*******************************************************************************
* Copyright (c) 2010-present Sonatype, Inc.
Copy link
Contributor

@kwin kwin Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonatype copyright?

Copy link
Member Author

@cstamas cstamas Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/PostConstruct.java Outdated
* http://www.eclipse.org/legal/epl-v10.html
*
* Contributors:
* Stuart McCulloch (Sonatype, Inc.) - initial API and implementation
Copy link
Contributor

@kwin kwin Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t that be you @cstamas?

Copy link
Member Author

@cstamas cstamas Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/bean/LifecycleModule.java Outdated
* Guice {@link Module} that provides JSR250 lifecycle management by following {@link PostConstruct} and
* {@link PreDestroy} annotations. The lifecycle can be controlled with the associated {@link BeanManager}.
* Guice {@link Module} that provides JSR250 lifecycle management by following {@link javax.annotation.PostConstruct} and
* {@link javax.annotation.PreDestroy} annotations. The lifecycle can be controlled with the associated {@link BeanManager}.
Copy link
Contributor

@kwin kwin Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or sisu lifecycle annotations!

Copy link
Member Author

@cstamas cstamas Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, please reread

@cstamas
Copy link
Member Author

cstamas commented Feb 18, 2023 •
edited
Loading

Re copyright: am really unsure here, @mcculls ? The "old" files DO have (and should keep) these Sonatype headers, but am unsure whhat headers "newly added" files should carry...

@mcculls
Copy link
Contributor

mcculls commented Feb 18, 2023

Hi @cstamas - for new files you can put your name under both the copyright and contributor lines, following the convention described in https://www.eclipse.org/projects/handbook/#ip-copyright-headers

@cstamas
Copy link
Member Author

cstamas commented Feb 18, 2023

Personally, but as practical option (as linked doco lists 4th bullet as optional), I'd rather do something like "Sisu Project" or nothing at all for 4th bullet, just standard eclipse header. Wdyt?

My thinking is toward simpler formatting/validation, but may be wrong in that respect...

@mcculls
Copy link
Contributor

mcculls commented Feb 19, 2023

Alternatively we could move to the more generic header and put copyright details in the NOTICE file - WDYT?

/********************************************************************************
 * Copyright (c) {year} Contributors to the Eclipse Foundation
 *
 * See the NOTICE file(s) distributed with this work for additional
 * information regarding copyright ownership.
 *
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Public License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/legal/epl-v10.html
 *
 * SPDX-License-Identifier: EPL-1.0
 ********************************************************************************/

@cstamas
Copy link
Member Author

cstamas commented Feb 20, 2023

Applied header @mcculls proposed

@cstamas cstamas merged commit bfbca8a into eclipse-sisu:master Feb 27, 2023
@cstamas cstamas deleted the issue-58 branch February 27, 2023 10:57
@cstamas cstamas mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls approved these changes

@kwin kwin kwin approved these changes

Assignees

@cstamas cstamas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PreConstruct PreDestroy should be own annotations

3 participants

@cstamas @mcculls @kwin