Do not silently fail in case of class scanning exceptions#98
Conversation
|
@cstamas Any idea how to make this configurable from Maven? Do we really want to extend the Plexus Container API for that? |
| try | ||
| { | ||
| new SpaceScanner( _space ).accept( this ); | ||
| new SpaceScanner( _space, true ).accept( this ); |
There was a problem hiding this comment.
I guess being always strict here should be fine
| void scanForElements( final Binder binder ) | ||
| { | ||
| new SpaceScanner( space, finder ).accept( strategy.visitor( binder ) ); | ||
| new SpaceScanner( space, finder, true ).accept( strategy.visitor( binder ) ); |
There was a problem hiding this comment.
this should probably expose a way on how to toggle the strict flag.
kwin
force-pushed
the
feature/strict-space-scanner
branch
from
6b23ed9 to
f45f781
Compare
mcculls
left a comment
mcculls
left a comment
There was a problem hiding this comment.
I think the default mode should remain non-strict, for reasons discussed in #97 (comment)
We can still change the mode to strict when generating the index via annotation processing or the maven plugin. That should solve the main build-time issue without affecting runtime deployments.
|
@mcculls Can you be more specific, where exactly you want to keep the default behaviour of being lenient?
or anywhere else (which I missed in the list above) |
|
@mcculls Can you comment on the individual cases listed above? |
|
|
kwin
force-pushed
the
feature/strict-space-scanner
branch
from
c6b97c6 to
7bc2ae3
Compare
@mcculls done now, can you check again? |
|
If there are no further concerns @mcculls I am gonna merge end of this week. |
2 participants
This closes #97