Skip to content

Add access to transport SHM provider#1132

Merged
yellowhatter merged 19 commits intoeclipse-zenoh:mainfrom
ZettaScaleLabs:transport_shm_provider
Nov 21, 2025
Merged

Add access to transport SHM provider#1132
yellowhatter merged 19 commits intoeclipse-zenoh:mainfrom
ZettaScaleLabs:transport_shm_provider

Conversation

@yellowhatter
Copy link
Contributor

No description provided.

@yellowhatter yellowhatter self-assigned this Nov 4, 2025
@yellowhatter yellowhatter added release Part of the next release api sync Synchronize API with other bindings labels Nov 4, 2025
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

PR missing one of the required labels: {'breaking-change', 'bug', 'api-sync', 'new feature', 'internal', 'documentation', 'enhancement', 'ci', 'dependencies'}

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

PR missing one of the required labels: {'breaking-change', 'dependencies', 'documentation', 'ci', 'enhancement', 'internal', 'bug', 'new feature', 'api-sync'}

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

PR missing one of the required labels: {'enhancement', 'dependencies', 'bug', 'new feature', 'ci', 'internal', 'api-sync', 'breaking-change', 'documentation'}

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

PR missing one of the required labels: {'dependencies', 'enhancement', 'api-sync', 'ci', 'breaking-change', 'documentation', 'new feature', 'internal', 'bug'}

@yellowhatter yellowhatter added the enhancement Existing things could work better label Nov 5, 2025
Copy link
Contributor

@milyin milyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the z_get_shm_provider should return z_result_t, like other owned object constructors. The enum can be in output variable. Everything else is ok for me

@yellowhatter
Copy link
Contributor Author

I think that the z_get_shm_provider should return z_result_t, like other owned object constructors. The enum can be in output variable. Everything else is ok for me

fixed

@yellowhatter yellowhatter requested a review from milyin November 7, 2025 14:30
@yellowhatter yellowhatter requested a review from milyin November 20, 2025 20:45
@yellowhatter yellowhatter merged commit 8a163bf into eclipse-zenoh:main Nov 21, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api sync Synchronize API with other bindings enhancement Existing things could work better release Part of the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants