Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
+ Coverage 71.00% 71.07% +0.06%
==========================================
Files 370 370
Lines 62857 62781 -76
==========================================
- Hits 44634 44621 -13
+ Misses 18223 18160 -63 ☔ View full report in Codecov by Sentry. |
wyfo
left a comment
There was a problem hiding this comment.
Could you add alphabetical sorting? I remember having tried taplo for zenoh a while ago, and having trouble with sorting, but I'm don't remember exactly what the problem was (maybe dependency feature sorting).
Also, we should do the same in all other zenoh repository.
Done. I chose not to set
Eventually! But let's not move the goalpost and instead see how this goes before we generalize to all repos. I'm also making this into a draft so it wouldn't interfere with the coming release (cc @diogomatsubara). |
@fuzzypixelz release is done, so feel free to merge whenever it's ready. |
|
Use a pre-commit hook like https://github.com/ComPWA/taplo-pre-commit to have automatic installation. |
b394bf6 to
e19fe06
Compare
Taplo is a TOML toolkit. It is the default LSP implementation used in Zed and the popular "Even Better TOML" VS Code extension. This commit leverages Taplo to ensure uniform TOML formatting in CI and locally (through precommit hooks), thus removing patch pollution due to TOML formatting changes. Note Arrays and keys are ordered alphabetically, but not inline table keys (otherwise `features` would go before `version` in Cargo Manifest files. This is a temporary solution until the question of TOML formatting is resolved upstream.
Taplo is a TOML toolkit. It is the default LSP implementation used in Zed and the popular "Even Better TOML" VS Code extension.
This commit leverages Taplo to ensure uniform TOML formatting in CI and locally (through precommit hooks), thus removing patch pollution due to TOML formatting changes.
This is a temporary solution until the question of TOML formatting is resolved upstream: rust-lang/rustfmt#4091.