Savvas/develop/fix valid time (#1932)

* Fix valid_time bug for observations. Add new titles

* Linting

* Minor error corrected

* Fix minor error and font size

* Linting

Author: SavvasMel

packages/evaluate/src/weathergen/evaluate/plotting/plotter.py

@@ -401,10 +401,7 @@ def create_maps_per_sample(
                         region,
                         tag=tag,
                         map_kwargs=dict(map_kwargs.get(var, {})) | map_kwargs_global,
-                        title=(
-                            f"{self.stream}, {var} : fstep = {self.fstep:03} "
-                            f"({format_datetime(valid_time)})"
-                        ),
+                        title=self.get_map_title(var, valid_time, da_t),
                     )
                     plot_names.append(name)
 
@@ -506,7 +503,7 @@ def scatter_plot(
         )
 
         plt.colorbar(scatter_plt, ax=ax, orientation="horizontal", label=f"Variable: {varname}")
-        plt.title(title)
+        plt.title(title, fontsize=9.5)
         if regionname == "global":
             ax.set_global()
         else:
@@ -628,6 +625,22 @@ def animation(self, samples, fsteps, variables, select, tag) -> list[str]:
     def get_map_output_dir(self, tag):
         return self.out_plot_basedir / self.stream / "maps" / tag
 
+    def get_map_title(self, var, valid_time, data):
+        title = f"{self.stream}, {var} : fstep = {self.fstep:03}"
+        if valid_time is not None:
+            title += f" ({format_datetime(valid_time)})"
+        elif "valid_time" in data.coords:
+            valid_time_start = data["valid_time"].values.min()
+            valid_time_end = data["valid_time"].values.max()
+            if valid_time_start != valid_time_end:
+                title += (
+                    f" ({format_datetime(valid_time_start)} - {format_datetime(valid_time_end)})"
+                )
+            else:
+                title += f" ({format_datetime(valid_time_start)})"
+
+        return title
+
 
 class LinePlots:
     def __init__(self, plotter_cfg: dict, output_basedir: str | Path):

packages/evaluate/src/weathergen/evaluate/utils/utils.py

@@ -430,7 +430,8 @@ def plot_data(reader: Reader, stream: str, global_plotting_opts: dict) -> None:
         "fig_size": global_plotting_opts.get("fig_size", (8, 10)),
         "fps": global_plotting_opts.get("fps", 2),
         "regions": global_plotting_opts.get("regions", ["global"]),
-        "plot_subtimesteps": reader.get_inference_stream_attr(stream, "tokenize_spacetime", False),
+        "plot_subtimesteps": reader.get_inference_stream_attr(stream, "tokenize_spacetime", False)
+        | plot_settings.get("plot_subtimesteps", False),
     }
     plotter = Plotter(plotter_cfg, reader.runplot_dir)
 

src/weathergen/model/embeddings.py

@@ -142,7 +142,7 @@ def forward_channels(self, x_in):
         x = peh(self.embed(x_in.transpose(-2, -1)))
 
         for layer in self.layers:
-            x = checkpoint(layer,x, use_reentrant=False)
+            x = checkpoint(layer, x, use_reentrant=False)
 
         # read out
         if self.unembed_mode == "full":