Skip to content

Fix valid_time bug#1932

Merged
SavvasMel merged 5 commits intoecmwf:developfrom
SavvasMel:Savvas/develop/fix_valid_time
Feb 26, 2026
Merged

Fix valid_time bug#1932
SavvasMel merged 5 commits intoecmwf:developfrom
SavvasMel:Savvas/develop/fix_valid_time

Conversation

@SavvasMel
Copy link
Contributor

@SavvasMel SavvasMel commented Feb 26, 2026

Description

With this PR, we distinguish cases in valid_times for the global maps, and we adapt the titles accordingly.

Issue Number

Closes #1913

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@SavvasMel SavvasMel marked this pull request as draft February 26, 2026 08:24
@SavvasMel
Copy link
Contributor Author

SavvasMel commented Feb 26, 2026

image image image

@SavvasMel SavvasMel marked this pull request as ready for review February 26, 2026 09:37
@SavvasMel SavvasMel merged commit 730ee72 into ecmwf:develop Feb 26, 2026
7 checks passed
@SavvasMel SavvasMel changed the title Savvas/develop/fix valid time Fix valid_time bug Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Eval breaks for fine-tuning data

2 participants