Skip to content

fix: support dicts of supporting_arrays#229

Merged
JPXKQX merged 3 commits intomainfrom
feat/support-dicts-of-dicts-metadata
Oct 21, 2025
Merged

fix: support dicts of supporting_arrays#229
JPXKQX merged 3 commits intomainfrom
feat/support-dicts-of-dicts-metadata

Conversation

@JPXKQX
Copy link
Member

@JPXKQX JPXKQX commented Oct 20, 2025

Description

This is need to support passing dict[str, dict[str, np.ndarray]] as supporting arrays to the save_metadata() funcition.

What problem does this change solve?

What issue or task does this change relate to?

Additional notes

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@floriankrb floriankrb self-requested a review October 21, 2025 06:37
@JPXKQX JPXKQX merged commit 9badbad into main Oct 21, 2025
73 of 74 checks passed
@JPXKQX JPXKQX deleted the feat/support-dicts-of-dicts-metadata branch October 21, 2025 13:16
@github-project-automation github-project-automation bot moved this from To be triaged to Done in Anemoi-dev Oct 21, 2025
anaprietonem pushed a commit that referenced this pull request Oct 22, 2025
🤖 Automated Release PR

This PR was created by `release-please` to prepare the next release.
Once merged:

1. A new version tag will be created
2. A GitHub release will be published
3. The changelog will be updated

Changes to be included in the next release:
---


##
[0.4.38](0.4.37...0.4.38)
(2025-10-22)


### Features

* **testing:** Add download timeout
([#230](#230))
([721d114](721d114))
* **testing:** Sane test data download retries
([#227](#227))
([1e08996](1e08996))


### Bug Fixes

* Fix frequency_to_string outputing 108000s
([#216](#216))
([5806a0c](5806a0c))
* Support dicts of supporting_arrays
([#229](#229))
([9badbad](9badbad))

---
> [!IMPORTANT]
> Please do not change the PR title, manifest file, or any other
automatically generated content in this PR unless you understand the
implications. Changes here can break the release process.
> ⚠️ Merging this PR will:
> - Create a new release
> - Trigger deployment pipelines
> - Update package versions

 **Before merging:**
 - Ensure all tests pass
 - Review the changelog carefully
 - Get required approvals

[Release-please
documentation](https://github.com/googleapis/release-please)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants