Conversation
anaprietonem
previously approved these changes
Oct 16, 2025
Collaborator
anaprietonem
left a comment
anaprietonem
left a comment
There was a problem hiding this comment.
Thanks Gert for spotting this, I'd say we could even drop the retries to 5, so dev and users just wait max 5 minutes rather than 10, but no strong feelings either
anaprietonem
approved these changes
Oct 20, 2025
anaprietonem
pushed a commit
that referenced
this pull request
Oct 22, 2025
## Description Follow up of #227 : also add a timeout to the download function. By default there is no timeout on `requests.get` (which is used under the hood), so downloads could hang indefinitely if the server times out and doesn't close the connection. ***As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/*** By opening this pull request, I affirm that all authors agree to the [Contributor License Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md) ---------
anaprietonem
pushed a commit
that referenced
this pull request
Oct 22, 2025
🤖 Automated Release PR This PR was created by `release-please` to prepare the next release. Once merged: 1. A new version tag will be created 2. A GitHub release will be published 3. The changelog will be updated Changes to be included in the next release: --- ## [0.4.38](0.4.37...0.4.38) (2025-10-22) ### Features * **testing:** Add download timeout ([#230](#230)) ([721d114](721d114)) * **testing:** Sane test data download retries ([#227](#227)) ([1e08996](1e08996)) ### Bug Fixes * Fix frequency_to_string outputing 108000s ([#216](#216)) ([5806a0c](5806a0c)) * Support dicts of supporting_arrays ([#229](#229)) ([9badbad](9badbad)) --- > [!IMPORTANT] > Please do not change the PR title, manifest file, or any other automatically generated content in this PR unless you understand the implications. Changes here can break the release process. >⚠️ Merging this PR will: > - Create a new release > - Trigger deployment pipelines > - Update package versions **Before merging:** - Ensure all tests pass - Review the changelog carefully - Get required approvals [Release-please documentation](https://github.com/googleapis/release-please)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default number of retries of
multiurl.downloadare very high:https://github.com/ecmwf/multiurl/blob/develop/multiurl/http.py#L54-L55
In case of network errors, it will retry for 16 hours. Lower this to a saner value. I believe this is one of the reasons the CI is sometimes hanging for a long time.
I chose arbitrary new values, input welcome.
Contributor Declaration
By opening this pull request, I affirm the following:
BEGIN_COMMIT_OVERRIDE
feat(testing): Sane test data download retries (#227)
END_COMMIT_OVERRIDE