feat(util): use native Map if available#966
Merged
plainheart merged 4 commits intoecomfe:masterfrom Nov 1, 2022
Merged
Conversation
plainheart
reviewed
Oct 22, 2022
pissang
reviewed
Oct 22, 2022
136f708 to
f3f22b6
Compare
plainheart
reviewed
Oct 26, 2022
plainheart
approved these changes
Oct 31, 2022
Contributor
Author
|
Appreciate the thorough review and helpful comments @plainheart @pissang 🙏 |
pissang
approved these changes
Nov 1, 2022
plainheart
added a commit
to apache/echarts
that referenced
this pull request
Nov 2, 2022
…der#966, change `hasOwnProperty` to `hasKey`.
8 tasks
Map if available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the discussion in #965
This PR is lacking tests, if the general direction is ok and validated, I will add the relevant tests.
From initial benchmarks