cli: require chart path when using enterprise access token#433
Merged
cli: require chart path when using enterprise access token#433
Conversation
✅ Deploy Preview for marblerun-docs canceled.
|
thomasten
force-pushed
the
feat/cli/require-chartpath-with-ent-token
branch
from
90e4578 to
eb97625
Compare
thomasten
force-pushed
the
feat/cli/require-chartpath-with-ent-token
branch
from
eb97625 to
5da1fa8
Compare
daniel-weisse
approved these changes
Jun 29, 2023
Member
daniel-weisse
left a comment
daniel-weisse
left a comment
There was a problem hiding this comment.
Accepting both formats for PATs sounds like a good idea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I can drop that commit if you have concerns (other auth secret formats?). Or I can add a simple heuristic, e.g., starting with ghp_Actually, I prefer accepting both inputs and convert the PAT automatically for convenience, so I've just added the check. Should be fine now. (Let me know if not.)