Skip to content

api: Implement a public Go API#658

Merged
daniel-weisse merged 16 commits into
masterfrom
feat/go-api
May 23, 2024
Merged

api: Implement a public Go API#658
daniel-weisse merged 16 commits into
masterfrom
feat/go-api

Conversation

@daniel-weisse
Copy link
Copy Markdown
Member

Proposed changes

  • Implement a public Go API
    • Provides an easy native Go interface for performing CLI commands that interact with the MarbleRun Coordinator
  • Use Go API as a backend for CLI commands
    • This removes the /cli/internal/rest package, as http calls are made by the API
      • Cert loading and writing from the rest package was moved to the new /cli/internal/certcache package
  • Heavily simplify the code in /internal/attestation and move it to /api/attestation
  • Add /api/v2/recover endpoint with better machine readable responses

Additional info

  • AB#4009
  • I would like to eventually also move the integration test to use the Go API, but as this PR is already quite a bit larger than I originally intended, this will be postponed to a different PR

@netlify
Copy link
Copy Markdown

netlify Bot commented May 16, 2024

Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit 2fdf9ee
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/664f02c303425c0007b85422

@daniel-weisse daniel-weisse force-pushed the feat/go-api branch 2 times, most recently from 5c3982f to c296f9f Compare May 16, 2024 09:46
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse requested a review from thomasten May 21, 2024 14:20
@daniel-weisse daniel-weisse marked this pull request as ready for review May 21, 2024 14:20
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Comment thread api/api.go
Comment thread api/api.go
Comment thread api/attestation/attestation.go Outdated
Comment thread api/attestation/attestation.go Outdated
Comment thread cli/internal/certcache/cert.go Outdated
Comment thread cli/internal/cmd/cmd.go Outdated
Comment thread internal/attestation/attestation.go Outdated
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse force-pushed the feat/go-api branch 2 times, most recently from 2e79a42 to 44a73be Compare May 23, 2024 08:37
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse merged commit 3e62cf3 into master May 23, 2024
@daniel-weisse daniel-weisse deleted the feat/go-api branch May 23, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants