coordinator: add manifest option to seal with unique key or disable sealing#677
Merged
Conversation
✅ Deploy Preview for marblerun-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thomasten
force-pushed
the
feat/coordinator/uniquekey
branch
from
12a787c to
6500c29
Compare
daniel-weisse
approved these changes
Jun 20, 2024
| if !s.recoveryMode && s.sealMode != seal.ModeDisabled { | ||
| sealedData, err := s.sealer.Seal(s.recoveryData, dataRaw) | ||
| if err != nil { | ||
| if !errors.Is(err, seal.ErrMissingEncryptionKey) { |
Member
There was a problem hiding this comment.
This introduces a change where we no longer write data to disk before a manifest is set.
I prefer the new behavior, but we might want to mention this in the changelog
daniel-weisse
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Coordinator uses the product key to seal the data. Users may want to use the unique key instead or disable persistent storage altogether for ephemeral deployments.
Proposed changes
Config.SealModefield to the manifest