Skip to content

premain: enable JSON formatted logs if EDG_LOG_FORMAT=json#766

Merged
daniel-weisse merged 3 commits intomasterfrom
dw/premain-json-log
Nov 20, 2024
Merged

premain: enable JSON formatted logs if EDG_LOG_FORMAT=json#766
daniel-weisse merged 3 commits intomasterfrom
dw/premain-json-log

Conversation

@daniel-weisse
Copy link
Copy Markdown
Member

Proposed changes

  • Fix two log messages of the marble-injector being incorrectly written at info level instead of error level
  • Enable JSON formatted logging for MarbleRun PreMain in case the EDG_LOG_FORMAT env variable is set to json
    • To ensure all log statements issued by the PreMain are JSON formatted, if enabled, changes to EGo and ERT are also required. ERT logs non JSON messages during bootup, e.g. here, and EGo does the same

Additional info

  • AB#4868

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 19, 2024

Deploy Preview for marblerun-docs ready!

Name Link
🔨 Latest commit 1a35095
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/673de6fe064b860008d51ce0
😎 Deploy Preview https://deploy-preview-766--marblerun-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@thomasten thomasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can take care of ERT/EGo

Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse merged commit 82ce121 into master Nov 20, 2024
@daniel-weisse daniel-weisse deleted the dw/premain-json-log branch November 20, 2024 14:21
@daniel-weisse daniel-weisse added the feature This change introduces new functionality label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature This change introduces new functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants