coordinator: fix equality checks for manifest properties#777
Merged
daniel-weisse merged 2 commits intomasterfrom Dec 16, 2024
Merged
coordinator: fix equality checks for manifest properties#777daniel-weisse merged 2 commits intomasterfrom
daniel-weisse merged 2 commits intomasterfrom
Conversation
daniel-weisse
added
the
bug fix
✅ Deploy Preview for marblerun-docs canceled.
|
daniel-weisse
force-pushed
the
dw/fix-equality-checks
branch
from
0fd5a94 to
71010d1
Compare
thomasten
approved these changes
Dec 13, 2024
…erties.Equal Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
dw/fix-equality-checks
branch
from
71010d1 to
0607107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two missing checks were preventing manifest updates from being properly applied if only these values changed
Proposed changes
DisableSecretBindinginmanifest.Marble.EqualAcceptedTCBStatusesandAcceptedAdvisoriesinquote.PackageProperties.Equal