cli: fix certificate command errors when --insecure flag is set#790
Merged
daniel-weisse merged 1 commit intomasterfrom Jan 15, 2025
Merged
cli: fix certificate command errors when --insecure flag is set#790daniel-weisse merged 1 commit intomasterfrom
--insecure flag is set#790daniel-weisse merged 1 commit intomasterfrom
Conversation
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
added
the
bug fix
✅ Deploy Preview for marblerun-docs canceled.
|
thomasten
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
marblerun certificatecommands check the remote coordinator's root certificate against the certificate cached on the local system. In case the--insecureflag is set, the cached certificate is not loaded, resulting in a comparison of the remote cert againstnil.--insecureflag is set.