Skip to content

charts: allow configuration of Coordinator PVC size through helm values file#793

Merged
daniel-weisse merged 1 commit intoedgelesssys:masterfrom
Nabsku:feature/allow-setting-size-of-pvc
Jan 29, 2025
Merged

charts: allow configuration of Coordinator PVC size through helm values file#793
daniel-weisse merged 1 commit intoedgelesssys:masterfrom
Nabsku:feature/allow-setting-size-of-pvc

Conversation

@Nabsku
Copy link
Copy Markdown
Contributor

@Nabsku Nabsku commented Jan 28, 2025

Proposed changes

  • Some storage backends such as NetApp Trident technically only allow volumes bigger than 20Mi. We instead deploy a separate claim now that we use in the marblerun chart. As a little UX improvement I propose that we allow setting the pvc size via the values.yaml file

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit 8717e8b
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/6798e78fbb24aa00084d7f53

daniel-weisse
daniel-weisse approved these changes Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@daniel-weisse daniel-weisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@daniel-weisse daniel-weisse added the changelog This PR should be part of the changelog, but isn't a feature, bug-fix, or breaking-change label Jan 29, 2025
@daniel-weisse daniel-weisse changed the title Added the ability to configure the size of the PVC charts: allow configuration of Coordinator PVC size through helm values file Jan 29, 2025
@daniel-weisse daniel-weisse merged commit 701a308 into edgelesssys:master Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-weisse daniel-weisse daniel-weisse approved these changes

Assignees

No one assigned

Labels

changelog This PR should be part of the changelog, but isn't a feature, bug-fix, or breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nabsku @CLAassistant @daniel-weisse