Skip to content

cli: accept both PKCS#8 and PKCS#1 private keys for recovery#798

Merged
daniel-weisse merged 3 commits intomasterfrom
dw/fix-private-key-parsing
Feb 5, 2025
Merged

cli: accept both PKCS#8 and PKCS#1 private keys for recovery#798
daniel-weisse merged 3 commits intomasterfrom
dw/fix-private-key-parsing

Conversation

@daniel-weisse
Copy link
Copy Markdown
Member

Proposed changes

  • accept both PKCS#8 and PKCS#1 private keys for marblerun recover
  • add a hint to the v1.7 docs about the CLI requiring PKCS#8 keys

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 5, 2025

Deploy Preview for marblerun-docs ready!

Name Link
🔨 Latest commit 28cc049
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/67a3411ddfa2780008361656
😎 Deploy Preview https://deploy-preview-798--marblerun-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-weisse daniel-weisse added the bug fix This change fixes a user facing bug from the previous release label Feb 5, 2025
@daniel-weisse daniel-weisse force-pushed the dw/fix-private-key-parsing branch from 25ababc to 1c8a848 Compare February 5, 2025 08:43
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
@daniel-weisse daniel-weisse force-pushed the dw/fix-private-key-parsing branch from 1c8a848 to 0f890e0 Compare February 5, 2025 09:09
Co-authored-by: Thomas Tendyck <51411342+thomasten@users.noreply.github.com>
@daniel-weisse daniel-weisse merged commit fcadb65 into master Feb 5, 2025
9 checks passed
@daniel-weisse daniel-weisse deleted the dw/fix-private-key-parsing branch February 5, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix This change fixes a user facing bug from the previous release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants