cli: allow specifying custom qcnl config when installing MarbleRun#851
Merged
daniel-weisse merged 4 commits intomasterfrom Sep 26, 2025
Merged
cli: allow specifying custom qcnl config when installing MarbleRun#851daniel-weisse merged 4 commits intomasterfrom
daniel-weisse merged 4 commits intomasterfrom
Conversation
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
✅ Deploy Preview for marblerun-docs canceled.
|
thomasten
requested changes
Sep 24, 2025
charts/templates/sgx_qcnl.yaml
Outdated
| USE_SECURE_CERT={{ .Values.dcap.useSecureCert }} | ||
| { | ||
| "pccs_url": "{{ .Values.dcap.pccsUrl }}", | ||
| "use_secure_cert": "{{ .Values.dcap.useSecureCert }}" |
Member
There was a problem hiding this comment.
I think this must be a json bool, not, e.g., "TRUE".
Member
Author
There was a problem hiding this comment.
Fixed
Also added a fallback for older CLI versions that still supply this value as a string
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
thomasten
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
marblerun install:--dcap-qcnl-config-file--dcap-pccs-urland--dcap-secure-certdcap.qcnlConfig--set-fileflag: