recovery: enable clients to send encrypted recovery secrets#878
Merged
daniel-weisse merged 6 commits intomasterfrom Nov 27, 2025
Merged
recovery: enable clients to send encrypted recovery secrets#878daniel-weisse merged 6 commits intomasterfrom
daniel-weisse merged 6 commits intomasterfrom
Conversation
✅ Deploy Preview for marblerun-docs canceled.
|
daniel-weisse
force-pushed
the
dw/encrypted-recovery
branch
from
b4e2104 to
201b09d
Compare
thomasten
requested changes
Nov 23, 2025
| // but the signature must always be generated over the plain recoverySecret. | ||
| // | ||
| // If this function is called from inside an EGo enclave, the "marblerun_ego_enclave" build tag must be set when building the binary. | ||
| func RecoverWithSignature(ctx context.Context, endpoint string, opts VerifyOptions, recoverySecret, recoverySecretSignature []byte) (remaining int, sgxQuote []byte, err error) { |
Member
There was a problem hiding this comment.
We need to expose this as a cli command. And we need means to create the signature on the air-gapped machine.
daniel-weisse
force-pushed
the
dw/encrypted-recovery
branch
from
201b09d to
2d9d1e9
Compare
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
dw/encrypted-recovery
branch
from
6dad5a4 to
460a613
Compare
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
dw/encrypted-recovery
branch
6 times, most recently
from
63d41b6 to
7c13916
Compare
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
daniel-weisse
force-pushed
the
dw/encrypted-recovery
branch
from
7c13916 to
629025c
Compare
thomasten
reviewed
Nov 26, 2025
Signed-off-by: Daniel Weiße <dw@edgeless.systems>
thomasten
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients may not want to bring the key material needed to decrypt the recovery secrets, or the recovery secrets themselves, onto machines exposed to the internet.
To enable a recovery workflow where the recovery secrets (or the needed key material) are kept on an airgapped machine, this PR adds a new endpoint to the Coordinator, allowing clients to retrieve an RSA public key generated by the Coordinator for the recovery workflow.
Clients can use this public key to encrypt their shares on the airgapped machine, transfer the encrypted share, and upload it to the Coordinator, where it is decrypted inside the SGX enclave.
Proposed changes
/api/v2/recover/public-keyto retrieve a public key generated for the recoveryTests