Skip to content

Comments

fix: properly type charset#134

Merged
hildjj merged 1 commit intoeditorconfig:mainfrom
SunsetTechuila:main
Jun 9, 2025
Merged

fix: properly type charset#134
hildjj merged 1 commit intoeditorconfig:mainfrom
SunsetTechuila:main

Conversation

@SunsetTechuila
Copy link
Member

@SunsetTechuila SunsetTechuila commented Jun 7, 2025

@hildjj
Copy link
Collaborator

hildjj commented Jun 7, 2025

I'll take a look at this. Need to do a release anyway.

@SunsetTechuila
Copy link
Member Author

SunsetTechuila commented Jun 8, 2025

since the core resolves unrecognized values as per the spec, you may also want to do something like this:

type AddAnyToValues<T extends object> = {
    [K in keyof T]: T[K] | Object;
};
export type PossibleKnownProps = AddAnyToValues<KnownProps>
export type Props = PossibleKnownProps & UnknownMap;

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15506034793

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.882%

Totals Coverage Status
Change from base Build 14556491785: 0.0%
Covered Lines: 706
Relevant Lines: 706

💛 - Coveralls

@hildjj hildjj merged commit 1208b7a into editorconfig:main Jun 9, 2025
11 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants