Allow the extension to be active in untrusted workspaces#364
Merged
SunsetTechuila merged 2 commits intoeditorconfig:mainfrom Feb 8, 2025
Merged
Allow the extension to be active in untrusted workspaces#364SunsetTechuila merged 2 commits intoeditorconfig:mainfrom
SunsetTechuila merged 2 commits intoeditorconfig:mainfrom
Conversation
Closes editorconfig#305 Just ran into this today. At an absolute minimum, the language definition and grammar should be available even in untrusted workspaces, but a quick look suggests that the generate command is also safe. There is no substitution in the template, plus the user would have to run the command manually. At worst, untrusted files could set their own `.editorconfig`, which only applies to files below in the directory hierarchy: This is probably wanted behavior even in an untrusted workspace.
RobLoach
approved these changes
Jul 23, 2024
SunsetTechuila
approved these changes
Feb 8, 2025
Member
SunsetTechuila
left a comment
SunsetTechuila
left a comment
There was a problem hiding this comment.
don't see how this can compromise security in any meaningful way
Member
|
thanks for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #305
Just ran into this today. At an absolute minimum, the language definition and grammar should be available even in untrusted workspaces, but a quick look suggests that the generate command is also safe. There is no substitution in the template, plus the user would have to run the command manually. At worst, untrusted files could set their own
.editorconfig, which only applies to files below in the directory hierarchy: This is probably wanted behavior even in an untrusted workspace.If maintainers do decide some parts of the extension are too dangerous for untrusted workspaces, it is still possible to provide the language and grammar definitions.
Please fill in this template.
tscw/o errors (same asnpm run compile).npm run lintw/o errors.