Skip to content

Comments

fix flaky test#386

Merged
xuhdev merged 2 commits intoeditorconfig:mainfrom
SunsetTechuila:fix-flaky-tests
Jan 31, 2025
Merged

fix flaky test#386
xuhdev merged 2 commits intoeditorconfig:mainfrom
SunsetTechuila:fix-flaky-tests

Conversation

@SunsetTechuila
Copy link
Member

@SunsetTechuila SunsetTechuila commented Jan 31, 2025

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run build).
  • Run npm run lint w/o errors.

after #372, applying changes sometimes takes a bit longer than 50ms, and this creates a race condition

workflow with this change has run 7 times without failure

Copy link
Member

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xuhdev xuhdev merged commit efc1dea into editorconfig:main Jan 31, 2025
9 checks passed
@SunsetTechuila SunsetTechuila deleted the fix-flaky-tests branch January 31, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants