fix: improve the commands output

[MaferMazu]

Description

This PR uses tutor_utils.execute() in the enable-private-packages and enable-themes commands to make debugging easier when they are inside the extra-commands command.

Pd: I couldn't use tutor_utils.execute() in extra-commands, because it uses chained commands.

More info about that util: https://github.com/overhangio/tutor/blob/v18.1.3/tutor/utils.py#L210

Also, check for themes to be dictionaries to avoid the type ignore comments.

How to test

• If the tests pass, the commands work as expected (See the integration test for more info).
• Run: tutor picasso run-extra-commands with this branch using the enable-themes and enable-private-packages inside. (See the screenshots for this test).
• Search for the logs in a building process. Example: https://github.com/eduNEXT/ednx-strains/actions/runs/11021514034

Screenshots

Using in the config.yml:

PICASSO_EXTRA_COMMANDS:
- tutor plugins update
- tutor picasso enable-themes
- tutor picasso enable-private-packages
- tutor config save

Before

After

After merge

• Publish new release.
• Update the release in picasso: https://github.com/eduNEXT/picasso/blob/main/.github/workflows/build.yml#L114

[mariajgrimaldi]

I don't want this to be a blocker since the design of running multiple commands is out of the scope of this PR, so please, don't consider it one.

Why can't we use tutor_utils.execute instead of directly calling subprocess.Popen? It will save us a lot of trouble since we won't have to handle errors or echo the command info manually.

[MaferMazu]

I tried, but it makes the chained elements weird.

For example:
Using: tutor_utils.execute(*command.split()) it returns:
tutor plugins update '|' tutor plugins index add https://raw.githubusercontent.com/eduNEXT/tutor-plugin-indexes/picasso_test/
To make it possible to allow chained elements, we would need to add shell=True in https://github.com/overhangio/tutor/blob/master/tutor/utils.py#L216

[MaferMazu]

I found a way:
Using: tutor_utils.execute('sh', '-c', command)
The only thing that is not so good about this is that every command will have a sh -c prefix:

[MaferMazu]

I used this solution. Having the sh -c prefix is not good looking but improves the readability of the code and doesn't bother a lot in the logs.

If you have more feedback about this, please let me know.

[mariajgrimaldi]

This looks significantly better and gives even more information for debugging purposes. I tested it and it's working as expected. Thank you!

[BryanttV]

Hi @MaferMazu, thanks for the PR!
Could we show in the cover letter the before and after the commands output?

[MaferMazu]

Thanks, @mariajgrimaldi @BryanttV, for the feedback. I applied it. I would love your re-review.

[BryanttV]

LGTM!