Skip to content

Allowing later versions of mingw from chocolatey#3

Closed
Honeybunch wants to merge 1 commit intoegor-tensin:masterfrom
Honeybunch:master
Closed

Allowing later versions of mingw from chocolatey#3
Honeybunch wants to merge 1 commit intoegor-tensin:masterfrom
Honeybunch:master

Conversation

@Honeybunch
Copy link
Copy Markdown

@Honeybunch Honeybunch commented May 14, 2022

I ran into some code for a PR here: KhronosGroup/KTX-Software#574
Where I needed a newer version of gcc from mingw to avoid some compiler bugs. The newer version of mingw on chocolatey seems to work fine so I removed the explicit versioning

@jonesmz
Copy link
Copy Markdown

jonesmz commented Jun 11, 2022

I second this. I think i'm running into a bug caused by older mingw.

Ideally this could be exposed as an option.

@chronoxor
Copy link
Copy Markdown

MinGW version 8.1.0 is far to old. New builds are available here: https://github.com/niXman/mingw-builds-binaries/releases

@coffeebe4code
Copy link
Copy Markdown

I vote this be an optional parameter to the runner like cc, static, etc.

I could see a default value being 8.1.0.

This would prevent others who rely on an older version of gcc, pthreads, or other libraries.

@coffeebe4code
Copy link
Copy Markdown

coffeebe4code commented Jul 29, 2022

I have a PR which allows for an optional version, this would allow the github action to use the same v2. Unless that is a requirement for github actions to increase every time. If we can't get this merged in within a week or two, I might just use my branch and action. I also would like to see if we can add caching or a custom image, so the install time isn't 5 plus minutes.

#7

@egor-tensin
Copy link
Copy Markdown
Owner

Sorry, I was in no fit state to deal with my GitHub Actions for the past year. I'll try to keep up in the future.

This has been implemented by somebody else and released. Thank you very much for your input.

@egor-tensin egor-tensin closed this Jan 7, 2023
@coffeebe4code
Copy link
Copy Markdown

coffeebe4code commented Apr 9, 2023

You PR'd the wrong one imo. I moved on from this project and action, but you would have broken anyone trying to rely on the default being 8.1.0. You made it so they can't install a specific version either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants