fix npm_url in install_npm_win#233
Merged
ekalinin merged 1 commit intoekalinin:masterfrom Feb 28, 2019
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoking nodeenv with an explicit version of npm (
--npm=6.8.0) failed on Windows because the archive URL was set to https://github.com/npm/cli/archive/6.8.0.zip rather than https://github.com/npm/cli/archive/v6.8.0.zip:Using
--npm=v6.8.0would also fail, because after unzipping the archive nodeenv would attempt to accesscli-v6.8.0rather than the correct directorycli-6.8.0:I just added the
v.