Support for Git-bash on Windows.#238
Closed
jwmcgettigan wants to merge 1 commit intoekalinin:masterfrom
jwmcgettigan:feature/git-bash-support
Closed
Support for Git-bash on Windows.#238jwmcgettigan wants to merge 1 commit intoekalinin:masterfrom jwmcgettigan:feature/git-bash-support
jwmcgettigan wants to merge 1 commit intoekalinin:masterfrom
jwmcgettigan:feature/git-bash-support
Conversation
Merged
|
I guess detecting if a In [1]: import shutil
In [2]: shutil.which("sh.exe")
Out[2]: 'C:\\Program Files\\Git\\bin\\sh.exe'
In [3]: shutil.which("bash.exe")
Out[3]: 'C:\\Program Files\\Git\\bin\\bash.exe'
In [4]: shutil.which("not_on_path.exe")
In [5]: type(shutil.which("not_on_path.exe"))
Out[5]: NoneTypeAt least for me the In [6]: import platform
In [7]: platform.system()
Out[7]: 'Windows'
In [8]: is_CYGWIN = platform.system().startswith(('CYGWIN', 'MSYS'))
In [9]: is_CYGWIN
Out[9]: FalseThe added bonus of this method would be that even if you create the end in a different console ( |
Owner
|
Looks like outdated. Thank anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only method I could think of for detecting if a user is in a bash environment on a Windows machine - and thus the best solution I could think of to issue #226 .
I've made it so that if the user is on a Windows machine, it will check whether they are running nodeenv from a bash.exe terminal (such as git-bash). This is being done using psutil to check the name of all parent processes and run/install/treat as CYGWIN instead of as Windows if a bash.exe process is detected among these parent processes.
Please let me know what you think of this solution.