Download musl-compatible nodeenv from unofficial-builds#247
Merged
ekalinin merged 2 commits intoekalinin:masterfrom Feb 10, 2020
asottile:muslc
Merged
Download musl-compatible nodeenv from unofficial-builds#247ekalinin merged 2 commits intoekalinin:masterfrom asottile:muslc
ekalinin merged 2 commits intoekalinin:masterfrom
asottile:muslc
Conversation
Contributor
Author
|
@ekalinin would appreciate a review on this one too! this fixes nodeenv to not use the deprecated structure and enables nodeenv to work out of the box on alpine / other muslc-based images |
Owner
|
@asottile thanks for the patch and sorry for delay. |
Contributor
Author
|
🎉 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #204
I needed to change the strategy of downloads due to unofficial-builds.nodejs.org having a slightly different structure -- fortunately, all three of
iojs.org/nodejs.organdunofficial-builds.nodejs.orgall have the new structure 🎉I tested this by mounting
nodeenv.pyinto an alpine docker image, after installinglibstdc++I was able to download and utilize a prebuilt nodeenv: