accept URL as well as domain name for --mirror argument#252
Merged
ekalinin merged 2 commits intoekalinin:masterfrom Apr 7, 2020
Merged
accept URL as well as domain name for --mirror argument#252ekalinin merged 2 commits intoekalinin:masterfrom
ekalinin merged 2 commits intoekalinin:masterfrom
Conversation
tchaikov
force-pushed
the
mirror-with-url
branch
from
7493daf to
e953890
Compare
Contributor
Author
|
tested using |
Contributor
Author
|
@ekalinin hi Eugene, anything i can do on my side to progress this change? |
Owner
|
Please, add:
|
tchaikov
force-pushed
the
mirror-with-url
branch
from
e953890 to
6d863af
Compare
Contributor
Author
|
@ekalinin hi Eugene, updated and repushed. could you please take another look? |
do not assume that the mirror mirrors the full directory structure of nodejs.org, actually, some mirros just have the part of `https://nodejs.org/download/release/` mirrored. for instance, https://npm.taobao.org/mirrors/node, and do not assume that the mirror always put the nodejs mirror in its `download/` directory. in this change, a URL is accepted as well as a domain name. if a mirror does not have "://" in it is specified, the default "https://<domain_name>/download/releases" URL is used. this change addresses the comment of ekalinin#208 (comment) also, ignore E127 for multi-line `with` statement, see discussion at PyCQA/pycodestyle#316, which is related to E126, but it also applies this case. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
node.js and io.js already merged back together since v4.0. and iojs.org redirects to nodejs.org. so, it does not make sense to offer this option for new developers using node.js >= 4.0 Signed-off-by: Kefu Chai <tchaikov@gmail.com>
tchaikov
force-pushed
the
mirror-with-url
branch
from
6d863af to
7d3bf01
Compare
|
@ekalinin If you have some time available, could you please look again at this pull request and make a new release? The --mirror improvement would be very helpfull to run nodeenv behind firewall in restricted environments. If a new release is made, would it be possible to also publish the source version again? (#251) |
Contributor
Author
|
@ekalinin hi Eugene ping? |
Owner
Contributor
Author
|
thank you, @ekalinin . fully understand. take care. |
Owner
|
thanks @tchaikov! take care too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not assume that the mirror mirrors the full directory structure of
nodejs.org, actually, some mirros just have the part of
https://nodejs.org/download/release/mirrored. for instance,https://npm.taobao.org/mirrors/node, and do not assume that the mirror
always put the nodejs mirror in its
download/directory.in this change, a URL is accepted as well as a domain name. if a mirror
does not have "://" in it is specified, the default
"https://<domain_name>/download/releases" URL is used.
this change addresses the comment of
#208 (comment)
Signed-off-by: Kefu Chai tchaikov@gmail.com