Fix tests, test Python 3.10, and run on tests on GitHub Actions#298
Merged
ekalinin merged 4 commits intoekalinin:masterfrom Jan 5, 2022
Merged
Fix tests, test Python 3.10, and run on tests on GitHub Actions#298ekalinin merged 4 commits intoekalinin:masterfrom
ekalinin merged 4 commits intoekalinin:masterfrom
Conversation
Fix: ``` tests/nodeenv_test.py:49 /home/runner/work/nodeenv/nodeenv/tests/nodeenv_test.py:49: PytestDeprecationWarning: @pytest.yield_fixture is deprecated. Use @pytest.fixture instead; they are the same. @pytest.yield_fixture ```
Fix this error: ``` nodeenv.py:359:80: E501 line too long (84 > 79 characters) ``` Added in 8e1c574
Missed in 8e1c574.
6cd4e4b to
73d800f
Compare
73d800f to
2461929
Compare
Contributor
Author
|
The test run needs approving on GitHub Actions. You can see a successful run on my fork’s actions tab: https://github.com/adamchainz/nodeenv/actions/runs/1659055175 |
Owner
Yeah, I understand. But they're a lot of projects still on py2.7. So, let's save 2.7 support for a while. Thank you! Great patch! |
Contributor
Author
|
Great, thank you for fast review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several commits, happy to split if appropriate.
Fix:
Fix this error:
Added in 8e1c574
Missed in 8e1c574.
Travis no longer posts results over to GitHub. I think this is how the previous failures went unseen. This commit removes the Travis config and adds a GitHub Actions one based on a recipe I use in my projects. This includes a method of combining Coverage results on GitHub Actions as per this blog post, removing the need for coveralls.
I removed Python 3.6, which is EOL, and added tests for Python 3.8 through 3.10. I didn’t remove 2.7 but would be happy to do so - it’s 2 years past its EOL.
I dropped the PyPy test run because the module is pure Python. I don’t think it’s worth the effort trying to test every library in existence with PyPy.